[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMbhsRR1HdG6QnNdrnD3y9DApnDR3RrUqFyTt5vZT0qR9n=ECg@mail.gmail.com>
Date: Fri, 9 Dec 2011 10:35:09 -0800
From: Colin Cross <ccross@...roid.com>
To: Peter De Schrijver <pdeschrijver@...dia.com>
Cc: Stephen Warren <swarren@...dia.com>,
Grant Likely <grant.likely@...retlab.ca>,
Rob Herring <rob.herring@...xeda.com>,
Randy Dunlap <rdunlap@...otime.net>,
Russell King <linux@....linux.org.uk>,
Olof Johansson <olof@...om.net>, Gary King <gking@...dia.com>,
"devicetree-discuss@...ts.ozlabs.org"
<devicetree-discuss@...ts.ozlabs.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v6 04/10] arm/tegra: prepare early init for multiple tegra variants
On Fri, Dec 9, 2011 at 3:19 AM, Peter De Schrijver
<pdeschrijver@...dia.com> wrote:
> On Thu, Dec 08, 2011 at 07:29:43PM +0100, Colin Cross wrote:
>> On Thu, Dec 8, 2011 at 9:57 AM, Stephen Warren <swarren@...dia.com> wrote:
>> > Peter De Schrijver wrote at Thursday, December 08, 2011 5:44 AM:
>> >> This patch splits the early init code in a common and a tegra20 specific part.
>> >> L2 cache initialization is generalized and discovers the cache associativity
>> >> at runtime. Also use arm_pm_restart instead of arm_arch_reset and reset the
>> >> the system using the PMC reset feature rather then the CAR system reset.
>> >
>> > This one really should be at least 3 separate patches:
>> > * s/tegra_init_early/tegra20_init_early/ in machine descriptions
>> > * Switch reset mechanism from CAR to PMC
>> > * tegra_init_cache modifications
>> > * Not sure if all the ifdef additions go in the above, or if some should be
>> > separate?
>> >
>> > Still, I think it's probably OK to go in as it is even if it isn't optimal.
>>
>> Please at least split out the reset change. Does using the PMC reset
>> instead of the CAR reset still result in a warm reset, or does it
>> change to a cold reset?
>
> What do you consider a cold reset in the tegra world?
Power rails turn off and on. Some of our debugging tools rely on
memory contents surviving across a reset, and that is generally true
of a warm reset, but not a cold reset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists