linux-kernel - Re: [PATCH RESEND 2/8] serial: 8250: Add ioctl to enable auto rs485 mode with some Exar UARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111209190019.0b983f48@pyramind.ukuu.org.uk>
Date:	Fri, 9 Dec 2011 19:00:19 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg KH <gregkh@...e.de>, Alan Cox <alan@...ux.intel.com>,
	Claudio Scordino <claudio@...dence.eu.com>,
	Matthias Fuchs <mfuchs@...fu.de>
Subject: Re: [PATCH RESEND 2/8] serial: 8250: Add ioctl to enable auto rs485
 mode with some Exar UARTs

On Fri,  9 Dec 2011 18:07:14 +0100
Wolfram Sang <w.sang@...gutronix.de> wrote:

> From: Matthias Fuchs <mfuchs@...fu.de>
> 
> Some Exar UARTs support an auto rs485 mode. In this mode
> the UART's RTS# pin is activated during transmitting and
> can be used to enable a rs485 line driver. This has nothing
> to do with attempts to do this by manually asserting/
> deasserting handshake lines in software.

Please split this out so that the ioctl handler calls a pair of port->
methods or errors if NULL. That'll future proof it and keep chip specific
stuff out of the direct paths.

Other than that I'm fine with it. Functionality, locking etc.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/