linux-kernel - Re: [PATCH] mm: simplify find_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 09 Dec 2011 15:44:53 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Hugh Dickins <hughd@...gle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Shaohua Li <shaohua.li@...el.com>
Subject: Re: [PATCH] mm: simplify find_vma_prev

> This changes the (undocumented, naturally) interface in disturbing ways.
>
> Currently, *pprev will always be written to.  With this change, *pprev
> will only be written to if find_vma_prev() returns non-NULL.
>
> Looking through the code, this is mostly benign.  But it will cause the
> CONFIG_STACK_GROWSUP version of find_extend_vma() to use an
> uninitialised stack slot in ways which surely will crash the kernel.

Weird.


> So please have a think about that and fix it up.  And please add
> documentation for find_vma_prev()'s interface so we don't break it next
> time.

Sure thing. Thank you for good spotting!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/