lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 9 Dec 2011 14:00:06 -0800
From:	Jonathan McDowell <noodles@...th.li>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org,
	Cory Maccarrone <darkstar6262@...il.com>,
	Laurent Gonzalez <palmte.linux@...e.fr>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	linux-fbdev@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/3] video: omap: convert drivers/video/omap/* to use
 module_platform_driver()

On Fri, Dec 09, 2011 at 09:24:29AM +0100, Marek Vasut wrote:
> > This patch converts the drivers in drivers/video/omap/* to use the
> > module_platform_driver() macro which makes the code smaller and a bit
> > simpler.
> > 
> > Cc: Jonathan McDowell <noodles@...th.li>
> > Cc: Cory Maccarrone <darkstar6262@...il.com>
> > Cc: Laurent Gonzalez <palmte.linux@...e.fr>
> > Cc: Marek Vasut <marek.vasut@...il.com>
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > ---
> >  drivers/video/omap/lcd_ams_delta.c |   13 +------------
> >  drivers/video/omap/lcd_h3.c        |   14 +-------------
> >  drivers/video/omap/lcd_htcherald.c |   14 +-------------
> >  drivers/video/omap/lcd_inn1510.c   |   14 +-------------
> >  drivers/video/omap/lcd_inn1610.c   |   14 +-------------
> >  drivers/video/omap/lcd_osk.c       |   14 +-------------
> >  drivers/video/omap/lcd_palmte.c    |   14 +-------------
> >  drivers/video/omap/lcd_palmtt.c    |   13 +------------
> >  drivers/video/omap/lcd_palmz71.c   |   13 +------------
> >  9 files changed, 9 insertions(+), 114 deletions(-)
> > 
> > diff --git a/drivers/video/omap/lcd_ams_delta.c
> > b/drivers/video/omap/lcd_ams_delta.c index eb50a95..0fdd6f6 100644
> > --- a/drivers/video/omap/lcd_ams_delta.c
> > +++ b/drivers/video/omap/lcd_ams_delta.c
> > @@ -209,15 +209,4 @@ static struct platform_driver ams_delta_panel_driver =
> > { },
> >  };
> > 
> > -static int __init ams_delta_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&ams_delta_panel_driver);
> > -}
> > -
> > -static void __exit ams_delta_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&ams_delta_panel_driver);
> > -}
> > -
> > -module_init(ams_delta_panel_drv_init);
> > -module_exit(ams_delta_panel_drv_cleanup);
> > +module_platform_driver(ams_delta_panel_driver);
> > diff --git a/drivers/video/omap/lcd_h3.c b/drivers/video/omap/lcd_h3.c
> > index baec34e..49bdeca 100644
> > --- a/drivers/video/omap/lcd_h3.c
> > +++ b/drivers/video/omap/lcd_h3.c
> > @@ -124,16 +124,4 @@ static struct platform_driver h3_panel_driver = {
> >  	},
> >  };
> > 
> > -static int __init h3_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&h3_panel_driver);
> > -}
> > -
> > -static void __exit h3_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&h3_panel_driver);
> > -}
> > -
> > -module_init(h3_panel_drv_init);
> > -module_exit(h3_panel_drv_cleanup);
> > -
> > +module_platform_driver(h3_panel_driver);
> > diff --git a/drivers/video/omap/lcd_htcherald.c
> > b/drivers/video/omap/lcd_htcherald.c index b1a022f..20f4778 100644
> > --- a/drivers/video/omap/lcd_htcherald.c
> > +++ b/drivers/video/omap/lcd_htcherald.c
> > @@ -115,16 +115,4 @@ static struct platform_driver htcherald_panel_driver =
> > { },
> >  };
> > 
> > -static int __init htcherald_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&htcherald_panel_driver);
> > -}
> > -
> > -static void __exit htcherald_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&htcherald_panel_driver);
> > -}
> > -
> > -module_init(htcherald_panel_drv_init);
> > -module_exit(htcherald_panel_drv_cleanup);
> > -
> > +module_platform_driver(htcherald_panel_driver);
> > diff --git a/drivers/video/omap/lcd_inn1510.c
> > b/drivers/video/omap/lcd_inn1510.c index d129946..b38b1dd 100644
> > --- a/drivers/video/omap/lcd_inn1510.c
> > +++ b/drivers/video/omap/lcd_inn1510.c
> > @@ -109,16 +109,4 @@ static struct platform_driver
> > innovator1510_panel_driver = { },
> >  };
> > 
> > -static int __init innovator1510_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&innovator1510_panel_driver);
> > -}
> > -
> > -static void __exit innovator1510_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&innovator1510_panel_driver);
> > -}
> > -
> > -module_init(innovator1510_panel_drv_init);
> > -module_exit(innovator1510_panel_drv_cleanup);
> > -
> > +module_platform_driver(innovator1510_panel_driver);
> > diff --git a/drivers/video/omap/lcd_inn1610.c
> > b/drivers/video/omap/lcd_inn1610.c index a95756b..7e8bd8e 100644
> > --- a/drivers/video/omap/lcd_inn1610.c
> > +++ b/drivers/video/omap/lcd_inn1610.c
> > @@ -133,16 +133,4 @@ static struct platform_driver
> > innovator1610_panel_driver = { },
> >  };
> > 
> > -static int __init innovator1610_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&innovator1610_panel_driver);
> > -}
> > -
> > -static void __exit innovator1610_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&innovator1610_panel_driver);
> > -}
> > -
> > -module_init(innovator1610_panel_drv_init);
> > -module_exit(innovator1610_panel_drv_cleanup);
> > -
> > +module_platform_driver(innovator1610_panel_driver);
> > diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c
> > index b985997..5914220 100644
> > --- a/drivers/video/omap/lcd_osk.c
> > +++ b/drivers/video/omap/lcd_osk.c
> > @@ -127,16 +127,4 @@ static struct platform_driver osk_panel_driver = {
> >  	},
> >  };
> > 
> > -static int __init osk_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&osk_panel_driver);
> > -}
> > -
> > -static void __exit osk_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&osk_panel_driver);
> > -}
> > -
> > -module_init(osk_panel_drv_init);
> > -module_exit(osk_panel_drv_cleanup);
> > -
> > +module_platform_driver(osk_panel_driver);
> > diff --git a/drivers/video/omap/lcd_palmte.c
> > b/drivers/video/omap/lcd_palmte.c index d79f436..88c31eb 100644
> > --- a/drivers/video/omap/lcd_palmte.c
> > +++ b/drivers/video/omap/lcd_palmte.c
> > @@ -108,16 +108,4 @@ static struct platform_driver palmte_panel_driver = {
> >  	},
> >  };
> > 
> > -static int __init palmte_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&palmte_panel_driver);
> > -}
> > -
> > -static void __exit palmte_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&palmte_panel_driver);
> > -}
> > -
> > -module_init(palmte_panel_drv_init);
> > -module_exit(palmte_panel_drv_cleanup);
> > -
> > +module_platform_driver(palmte_panel_driver);
> > diff --git a/drivers/video/omap/lcd_palmtt.c
> > b/drivers/video/omap/lcd_palmtt.c index c2e96a7..aaf3c8b 100644
> > --- a/drivers/video/omap/lcd_palmtt.c
> > +++ b/drivers/video/omap/lcd_palmtt.c
> > @@ -113,15 +113,4 @@ static struct platform_driver palmtt_panel_driver = {
> >  	},
> >  };
> > 
> > -static int __init palmtt_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&palmtt_panel_driver);
> > -}
> > -
> > -static void __exit palmtt_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&palmtt_panel_driver);
> > -}
> > -
> > -module_init(palmtt_panel_drv_init);
> > -module_exit(palmtt_panel_drv_cleanup);
> > +module_platform_driver(palmtt_panel_driver);
> > diff --git a/drivers/video/omap/lcd_palmz71.c
> > b/drivers/video/omap/lcd_palmz71.c index 1ab4847..3b7d8aa 100644
> > --- a/drivers/video/omap/lcd_palmz71.c
> > +++ b/drivers/video/omap/lcd_palmz71.c
> > @@ -109,15 +109,4 @@ static struct platform_driver palmz71_panel_driver = {
> >  	},
> >  };
> > 
> > -static int __init palmz71_panel_drv_init(void)
> > -{
> > -	return platform_driver_register(&palmz71_panel_driver);
> > -}
> > -
> > -static void __exit palmz71_panel_drv_cleanup(void)
> > -{
> > -	platform_driver_unregister(&palmz71_panel_driver);
> > -}
> > -
> > -module_init(palmz71_panel_drv_init);
> > -module_exit(palmz71_panel_drv_cleanup);
> > +module_platform_driver(palmz71_panel_driver);
> 
> PalmTT and PalmZ71, please add my
> Acked-by: Marek Vasut <marek.vasut@...il.com>

For ams-delta,

Acked-By: Jonathan McDowell <noodles@...th.li>

J.

-- 
                                            xmpp:noodles@...th.li
Time is an illusion. Lunchtime doubly so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ