linux-kernel - Re: [PATCH 03/30] Staging: comedi: fix printk issue in daqboard2000.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111209000048.GA31036@kroah.com>
Date:	Thu, 8 Dec 2011 16:00:48 -0800
From:	Greg KH <greg@...ah.com>
To:	Ravishankar karkala Mallikarjunayya 
	<ravishankar.km@...enturtles.in>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/30] Staging: comedi: fix printk issue in daqboard2000.c

On Thu, Dec 08, 2011 at 06:21:58PM +0530, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
> 
> Converted printks to pr_<levels>.
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@...enturtles.in>
> ---
>  drivers/staging/comedi/drivers/daqboard2000.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index a16060e..265c650 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -502,7 +502,7 @@ static int daqboard2000_ao_insn_write(struct comedi_device *dev,
>  
>  static void daqboard2000_resetLocalBus(struct comedi_device *dev)
>  {
> -	printk("daqboard2000_resetLocalBus\n");
> +	pr_debug("daqboard2000_resetLocalBus\n");

What's wrong with dev_dbg()?  Please use the dev_* functions wherever
possible, like here and in all of the other printk patches you sent.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/