linux-kernel - Re: [PATCH 2/2] regulator: add device tree support for max8997

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuYYwT5xrtxL8eajYDqb8dYWKDpe6RG7_BSk-ku9ecP+dfFvw@mail.gmail.com>
Date:	Fri, 9 Dec 2011 10:47:03 +0530
From:	Thomas Abraham <thomas.abraham@...aro.org>
To:	Kyungmin Park <kyungmin.park@...sung.com>
Cc:	linux-kernel@...r.kernel.org, rpurdie@...ys.net,
	rob.herring@...xeda.com, grant.likely@...retlab.ca,
	kgene.kim@...sung.com, broonie@...nsource.wolfsonmicro.com,
	myungjoo.ham@...sung.com, dg77.kim@...sung.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, Rajendra Nayak <rnayak@...com>
Subject: Re: [PATCH 2/2] regulator: add device tree support for max8997

Dear Mr. Park,

On 9 December 2011 08:00, Kyungmin Park <kyungmin.park@...sung.com> wrote:
> On 12/9/11, Thomas Abraham <thomas.abraham@...aro.org> wrote:
>> Add device tree based discovery support for max8997.
>>
>> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
>> Cc: Rajendra Nayak <rnayak@...com>
>> Cc: Rob Herring <rob.herring@...xeda.com>
>> Cc: Grant Likely <grant.likely@...retlab.ca>
>> Signed-off-by: Thomas Abraham <thomas.abraham@...aro.org>

[...]

>> +#else
>> +static int *max8997_i2c_parse_dt_pdata(struct device *dev
>> +                                     struct max8997_platform_data **pdata)
> It should be 'int' instead of 'int *'
>
> It's helpful to compile without CONFIG_OF.

I apologize for that. I compiled for exynos-dt first and then compiled
for origen board (which does not select CONFIG_OF). When compiling for
non-dt origen, I missed to notice that CONFIG_OF selection was left
over from the previous exynos-dt compile.

I have checked again without CONFIG_OF and found this issue as well as
two other errors/warnings.

Thanks. This was very helpful.

Regards,
Thomas.

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/