linux-kernel - Re: [PATCH] [media] uvcvideo: Use kcalloc instead of kzalloc to allocate array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201112120041.54884.laurent.pinchart@ideasonboard.com>
Date:	Mon, 12 Dec 2011 00:41:54 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	mchehab@...radead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] uvcvideo: Use kcalloc instead of kzalloc to allocate array

Hi Thomas,

Thanks for the patch.

On Tuesday 29 November 2011 22:08:00 Thomas Meyer wrote:
> The advantage of kcalloc is, that will prevent integer overflows which
> could result from the multiplication of number of elements and size and it
> is also a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Should I take the patch in my tree, or do you plan to push several similar 
patches directly in one go ?

> ---
> 
> diff -u -p a/drivers/media/video/uvc/uvc_ctrl.c
> b/drivers/media/video/uvc/uvc_ctrl.c ---
> a/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:36:47.613437745 +0100
> +++ b/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:58:26.309317018
> +0100 @@ -1861,7 +1861,7 @@ int uvc_ctrl_init_device(struct uvc_devi
>  		if (ncontrols == 0)
>  			continue;
> 
> -		entity->controls = kzalloc(ncontrols * sizeof(*ctrl),
> +		entity->controls = kcalloc(ncontrols, sizeof(*ctrl),
>  					   GFP_KERNEL);
>  		if (entity->controls == NULL)
>  			return -ENOMEM;

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/