linux-kernel - RE: [PATCHv2 01/10] xshm: Shared Memory layout for ST-E M7400 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 10:09:10 +0100
From:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Paul Bolle <pebolle@...cali.nl>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: RE: [PATCHv2 01/10] xshm: Shared Memory layout for ST-E M7400
 driver.

Hi Arnd,

> >  include/linux/xshm/xshm_ipctoc.h |  160
> ++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 160 insertions(+), 0 deletions(-)
> >  create mode 100644 include/linux/xshm/xshm_ipctoc.h
> 
> Generally, the include/linux path is for interfaces between modules, while
> hardware data structures should be in the same directory as the driver using
> them to provide an abstract interface.

Sure, I'll move this file to drivers/xshm.

> > +#pragma pack(1)
> 
> Better remove the #pragma. Marking data structures as packed when they
> are already packed to start with only leads to worse optimizations in the
> compiler, but does not have a functional impact.

Ok, I'll remove the #pragma in the next patch-set.

Regards,
Sjur