linux-kernel - Re: [PATCH] leds: mc13783: fix off-by-one for checking num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 10:45:28 +0100
From:	Philippe Rétornaz <philippe.retornaz@...l.ch>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] leds: mc13783: fix off-by-one for checking num_leds

Le samedi 10 décembre 2011 15:14:56 Axel Lin a écrit :
> The LED id is begin from 0.
> Thus the maximum number of leds should be MC13783_LED_MAX + 1.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/leds/leds-mc13783.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
> index c61e8c4..8bc4915 100644
> --- a/drivers/leds/leds-mc13783.c
> +++ b/drivers/leds/leds-mc13783.c
> @@ -275,7 +275,7 @@ static int __devinit mc13783_led_probe(struct
> platform_device *pdev) return -ENODEV;
>  	}
> 
> -	if (pdata->num_leds < 1 || pdata->num_leds > MC13783_LED_MAX) {
> +	if (pdata->num_leds < 1 || pdata->num_leds > (MC13783_LED_MAX + 1)) {
>  		dev_err(&pdev->dev, "Invalid led count %d\n", pdata->num_leds);
>  		return -EINVAL;
>  	}

Acked-by: Philippe Retornaz <philippe.retornaz@...l.ch>

Thanks ! 

Philippe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/