lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 12 Dec 2011 13:35:50 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Robin Holt <holt@....com>
Cc:	Greg Kroah-Hartmann <greg@...ah.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: question about link_mem_sections()

Robin,

you added find_memory_block_hinted() with:
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=63d027a63888e993545d10fdfe4107d543f01bca

I try to understand what's going on here, because we need to switch
away from 'struct sysdev'.

In the loop over the node data you call find_memory_block_hinted() in
a row, which might all take a reference. At the end of the section you
drop only the last reference of the iteration. The code before your
change dropped all references inside the loop.

Could you please explain the intended behaviour?

If all is right, we should at least move the now wrong comment where is belongs.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ