linux-kernel - Re: [PATCH 1/2] Add partition resize function to BLKPG ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111212180411.GE29180@redhat.com>
Date:	Mon, 12 Dec 2011 13:04:11 -0500
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Phillip Susi <psusi@....rr.com>, Karel Zak <kzak@...hat.com>,
	linux-kernel@...r.kernel.org, Jens Axboe <jaxboe@...ionio.com>
Subject: Re: [PATCH 1/2] Add partition resize function to BLKPG ioctl

On Mon, Dec 12, 2011 at 09:49:07AM -0800, Joe Perches wrote:
> On Mon, 2011-12-12 at 12:43 -0500, Phillip Susi wrote:
> > On 12/12/2011 09:53 AM, Vivek Goyal wrote:
> []
> > > - Can we rename BLKPG_RES_PARTITION to BLKPG_RESIZE_PARTITION. It is
> > >   easier to read.
> > BLKPG_DELETE_PARTITION is also easier to read, but the existing code
> > went with DEL.  I prefer to stay consistent with the existing code and
> > also use a 3 letter name.
> 
> RES is most commonly used for RESOURCE.
> 
> If it really needs to be 3 letters, and I don't think
> it does, perhaps BLKPG_RSZ_PARTITION

Agreed. RES does not occur to me as resize but resources. ADD and DEL
are very clear. 

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/