lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Dec 2011 19:28:07 +0100 From: Bastian Blank <bastian@...di.eu.org> To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Cc: xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org Subject: Re: [Xen-devel] [PATCH 6/6] xen/xenbus-backend: Only register device if communication ring is local On Mon, Dec 12, 2011 at 10:42:27AM -0500, Konrad Rzeszutek Wilk wrote: > On Sat, Dec 10, 2011 at 07:29:51PM +0100, Bastian Blank wrote: > > -module_init(xenbus_backend_init); > > -module_exit(xenbus_backend_exit); > > Why are we removing the module functionality? > Can't this [the purpose of this patch] be done while still maintaining the module functionality? Not really. The purpose is to register the device only if the ring is local. This information is not available to modules. However we could just move the whole xenbus ring setup into a "module". Or is there any reason for this to be in a postcore_initcall, even if it is only operational after a userspace process works? > > int xenstored_ready; > > > > +/* A flag to determine if xenstored is 'local' */ > > +#ifdef CONFIG_XEN_BACKEND > > +static int xenstored_local; > > bool? Well. The other flags are int also. > > + BUG(); > No way. A WARN, sure - but BUG() is way too intense for this. Okay. Bastian -- The sight of death frightens them [Earthers]. -- Kras the Klingon, "Friday's Child", stardate 3497.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists