linux-kernel - Re: [PATCH 2/2] acerhdf: Message logging neatening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 10:56:37 -0800
From:	Joe Perches <joe@...ches.com>
To:	Peter Feuerer <peter@...e.net>
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] acerhdf: Message logging neatening

On Mon, 2011-12-12 at 19:26 +0100, Peter Feuerer wrote:
> > @@ -605,8 +603,8 @@ static int acerhdf_check_hardware(void)
> >  	}
> >  
> >  	if (!bios_cfg) {
> > -		pr_err("unknown (unsupported) BIOS version %s/%s/%s, "
> > -			"please report, aborting!\n", vendor, product, version);
> > +		pr_err("unknown (unsupported) BIOS version %s/%s/%s, please report, aborting!\n",
> > +		       vendor, product, version);
> 
> disagree, as it exceeds 80 chars.

Format strings should be coalesced.
checkpatch ignores these long lines.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/