linux-kernel - [PATCH] perf tools: bad lookup in perf_evlist_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 20:48:51 +0100
From:	roel <roel.kluin@...il.com>
To:	acme@...hat.com, a.p.zijlstra@...llo.nl, mingo@...e.hu,
	paulus@...ba.org, akpm@...ux-foundation.org
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] perf tools: bad lookup in perf_evlist__equal()?

Fix lookup in perf_evlist__equal()

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
 tools/perf/builtin-record.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Unless this was a feature, but then a comment might be nice
This was introduced in a91e5431d54f5

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 6ab58cc..4ccb7d0 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -252,7 +252,7 @@ static bool perf_evlist__equal(struct perf_evlist *evlist,
 	pair = list_entry(other->entries.next, struct perf_evsel, node);
 
 	list_for_each_entry(pos, &evlist->entries, node) {
-		if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr) != 0))
+		if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr)) != 0)
 			return false;
 		pair = list_entry(pair->node.next, struct perf_evsel, node);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/