linux-kernel - [patch 00/23] dynamic-debug enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 16:12:02 -0700
From:	Jim Cromie <jim.cromie@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>,
	Jason Baron <jbaron@...hat.com>
Cc:	Greg KH <greg@...ah.com>
Subject: [patch 00/23] dynamic-debug enhancements

On Wed, Nov 30, 2011 at 1:27 PM, Jim Cromie <jim.cromie@...il.com> wrote:
> this patchset adds
> - dynamic-debug during module initialization
via $module.dyndbg
> - multiple queries in ddebug_query, module.dyndbg
>
> Unlike previous versions, it drops the pending-query approach in
> favor of  "fake module parameters"proposed by Thomas Renninger
>    https://lkml.org/lkml/2010/9/15/397
>

This revision fixes an overzealous rework in the previous;
the unknown-parameter callback from parse-args/parse-one
is not invoked in the boot-process, so boot-args were not picked up
for builtin modules, only for loadable modules.
So, this restores ddebug_boot_parse_args() to do that.

The char *modname added previously to the callback signature remains
(added in patch 18), this is needed by the callback (in patch 20), and is
unavailable in the param-name, which has already been stripped of its
module. prefix.
Im hoping this minor feature-before-use issue is forgettable; I could have
put patch 20 1st, but its useless unless modname is available,
which seemed to be a bigger violation.

I briefly looked at using a struct module* as pondered by Rusty,
and module:load_module() already uses it to fill args of params:parse_args(),
which would reduce sig to just (struct module*, callback*)
but other callers of parse_args, "booting kernel", "early options",
dont have a struct mod, and it seemed like massive overkill to dummy one up.
So I stuck with char *modname.

> Its based upon 3.2-rc3, since that has several patches to
> include/linux/dynamic_debug.h
> that are not in driver-core-next, and theyd need to be handled eventually.
>
> 1 - trivial bug in kernel/module.c under DEBUGP
> 2 - whitespace
> 3-12 dyndbg cleanups
> 13-17 multiple queries
> 18-23 dynamic-debug during module initialization
>
[jimc@...ucho linux-2.6]$ git diff --stat v3.2-rc3..HEAD
 Documentation/dynamic-debug-howto.txt |  156 +++++++++++-----
 Documentation/kernel-parameters.txt   |   23 ++-
 drivers/pnp/base.h                    |    8 +-
 drivers/pnp/core.c                    |   12 ++
 include/linux/device.h                |    8 +-
 include/linux/dynamic_debug.h         |   30 +++-
 include/linux/kernel.h                |   10 +
 include/linux/moduleparam.h           |    7 +-
 include/linux/netdevice.h             |    8 +-
 include/linux/printk.h                |    8 +-
 init/main.c                           |    5 +-
 kernel/module.c                       |   49 +++---
 kernel/params.c                       |   36 ++--
 lib/Kconfig.debug                     |   17 +-
 lib/dynamic_debug.c                   |  335 +++++++++++++++++++++++----------
 15 files changed, 483 insertions(+), 229 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/