linux-kernel - Re: [PATCH 02/06] MFD: DA9052/53 MFD core module v9 Added ADC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 12:52:59 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	linux-kernel@...r.kernel.org, Dajun <dajun.chen@...semi.com>,
	arnd@...db.de, linaro-dev@...ts.linaro.org, eric.miao@...aro.org
Subject: Re: [PATCH 02/06] MFD: DA9052/53 MFD core module v9 Added ADC support

On Fri, Dec 09, 2011 at 07:46:06PM +0530, Ashish Jangam wrote:

> +	req = kzalloc(sizeof(*req), GFP_KERNEL);
> +	if (!req)
> +		return -ENOMEM;

> +	init_completion(&req->done);
> +	req->input = channel;
> +
> +	if (channel > DA9052_ADC_VBBAT)
> +		return -EINVAL;

This will leak the request.

> +	list_del(&req->list);
> +err:
> +	mutex_unlock(&da9052->auxadc_lock);
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(da9052_adc_manual_read);

In fact is req freed at all?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/