linux-kernel - Re: [PATCH 03/06] MFD: DA9052/53 MFD core module v9 Added SPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111212050111.GC3216@opensource.wolfsonmicro.com>
Date:	Mon, 12 Dec 2011 13:01:13 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>,
	sameo@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org, Dajun <dajun.chen@...semi.com>,
	arnd@...db.de, linaro-dev@...ts.linaro.org, eric.miao@...aro.org
Subject: Re: [PATCH 03/06] MFD: DA9052/53 MFD core module v9 Added SPI support

On Fri, Dec 09, 2011 at 07:46:33PM +0530, Ashish Jangam wrote:
> The DA9052/53 is a highly integrated PMIC subsystem with supply domain
> flexibility to support wide range of high performance application.

Reviwed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Looks good, though again you should've CCed Samuel.  One small thing:

>  
>  	struct device *dev;
> +	struct spi_device *spi_dev;
>  	struct i2c_client *i2c_client;

You con't actually use this (or the i2c_client) any more so could just
drop them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/