linux-kernel - RE: [PATCH] bcd: limit bin2bcd input value to lie between 0-99

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D958900912E20642BCBC71664EFECE3E6DCD652AF0@BGMAIL02.nvidia.com>
Date:	Tue, 13 Dec 2011 15:26:28 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
	"bunk@...nel.org" <bunk@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] bcd: limit bin2bcd input value to lie between 0-99

Hi,

Can someone please approve this change or send comments in case of any more objections?

Thanks,
Venu


> -----Original Message-----
> From: Andrew Morton [mailto:akpm@...ux-foundation.org]
> Sent: Wednesday, November 23, 2011 4:02 AM
> To: Venu Byravarasu
> Cc: torvalds@...ux-foundation.org; a.zummo@...ertech.it; bunk@...nel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] bcd: limit bin2bcd input value to lie between 0-99
> 
> On Wed, 16 Nov 2011 10:41:32 +0530
> vbyravarasu@...dia.com wrote:
> 
> > From: venu byravarasu <vbyravarasu@...dia.com>
> >
> > Current implementation of bin2bcd allows any value
> > between 0x0 to 0xF to be stored in the most significant
> > nibble of its returned value, against to the BCD limits
> > of 0 - 9. Hence fixing it.
> >
> > e.g. say val passed to bin2bcd is 123.
> > In that case the expected value to be returned by
> > this function is 0x23.
> > However, without the fix being added, it would
> > return 0xC3.
> >
> 
> I'm not sure that I agree.  Passing 123 to bin2bcd() is a bug, isn't
> it?  We want to know about bugs so we can fix them, and quietly repairing
> thngs in callees prevents that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/