linux-kernel - [PATCH v2-rebased] mfd: TPS65910: Make usable even if interrupt unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323770273-21222-1-git-send-email-afzal@ti.com>
Date:	Tue, 13 Dec 2011 15:27:53 +0530
From:	Afzal Mohammed <afzal@...com>
To:	<sameo@...ux.intel.com>, <broonie@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>
CC:	<nsekhar@...com>, Afzal Mohammed <afzal@...com>
Subject: [PATCH v2-rebased] mfd: TPS65910: Make usable even if interrupt unused

TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about it

Signed-off-by: Afzal Mohammed <afzal@...com>
Reviewed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
---
Hi Samuel,

I sent this yesterday, but did not reach LKML,
so assumed you also may not have recieved it;
resending.

Regards
Afzal

 drivers/mfd/tps65910.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 6f5b8cf..2fa0178 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -172,15 +172,12 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
 
 	tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
 
-	ret = tps65910_irq_init(tps65910, init_data->irq, init_data);
-	if (ret < 0)
-		goto err;
+	tps65910_irq_init(tps65910, init_data->irq, init_data);
 
 	kfree(init_data);
 	return ret;
 
 err:
-	mfd_remove_devices(tps65910->dev);
 	kfree(tps65910);
 	kfree(init_data);
 	return ret;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/