linux-kernel - Re: [PATCH 1/2] gpio-ml-ioh: fix a bug in the interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111213180545.GC4871@ponder.secretlab.ca>
Date:	Tue, 13 Dec 2011 11:05:45 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Feng Tang <feng.tang@...el.com>
Cc:	linus.walleij@...aro.org, tomoya-linux@....lapis-semi.com,
	linux-kernel@...r.kernel.org, joel.clark@...el.com,
	ying.huang@...el.com, qi.wang@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH 1/2] gpio-ml-ioh: fix a bug in the interrupt handler

On Tue, Dec 13, 2011 at 11:53:49PM +0800, Feng Tang wrote:
> GPIO's irq action's dev_id is set to the first struct ioh_gpio chip,
> so when loop checking the 8 chips, the "chip" should be changed
> according.
> 
> Signed-off-by: Feng Tang <feng.tang@...el.com>

Applied, thanks.

g.

> ---
>  drivers/gpio/gpio-ml-ioh.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index ea8e738..92b6f51 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -339,7 +339,7 @@ static irqreturn_t ioh_gpio_handler(int irq, void *dev_id)
>  	int i, j;
>  	int ret = IRQ_NONE;
>  
> -	for (i = 0; i < 8; i++) {
> +	for (i = 0; i < 8; i++, chip++) {
>  		reg_val = ioread32(&chip->reg->regs[i].istatus);
>  		for (j = 0; j < num_ports[i]; j++) {
>  			if (reg_val & BIT(j)) {
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/