linux-kernel - Re: [PATCH] omap: rx51: initialize isp1704 properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111213200057.GA2965@earth.universe>
Date:	Tue, 13 Dec 2011 21:00:57 +0100
From:	Sebastian Reichel <sre@...ian.org>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	Heikki Krogerus <krohei@...il.com>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Kalle Jokiniemi <kalle.jokiniemi@...ia.com>,
	Anton Vorontsov <cbouatmailru@...il.com>
Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly

On Mon, Dec 12, 2011 at 11:44:45AM -0800, Tony Lindgren wrote:
> * Felipe Contreras <felipe.contreras@...il.com> [111208 11:52]:
> > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@...il.com> wrote:
> > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> > >> From: Heikki Krogerus <krohei@...il.com>
> > >
> > > I would prefer that you change this so this is from you, like it
> > > actually is. You can mention me in the commit message if you like.
> > 
> > Well, you came with the fix, I just typed it down, but as you wish :)
> > 
> > >> Without this USB networking doesn't work as the link is never detected.
> > >
> > > What this changes is, it leaves the transceiver powered by default
> > > instead of setting it into power off mode. So not only USB networking
> > > is affected by this. If isp1704_charger is not enabled with RX51, USB
> > > does not work at all. Please change the comment.
> > 
> > I've updated the patch.
> 
> Sorry what's the deal with this one? Is this the one to use or is there
> some other patch?

I can confirm, that USB on RX51 does not work with 3.1 mainline
kernel and applying this patch (There's a v2 with fixed Author under
[0]) results in working USB support.

[0] http://www.spinics.net/lists/linux-omap/msg61217.html

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)