linux-kernel - RE: [Pv-drivers] [PATCH] include/log2.h: Fix rounddown_pow_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1323806832.28489.1.camel@twins>
Date:	Tue, 13 Dec 2011 21:07:12 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Bhavesh Davda <bhavesh@...are.com>
Cc:	Dmitry Torokhov <dtor@...are.com>,
	Andrei Warkentin <awarkentin@...are.com>,
	"pv-drivers@...are.com" <pv-drivers@...are.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: RE: [Pv-drivers] [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)

On Tue, 2011-12-13 at 12:06 -0800, Bhavesh Davda wrote:
> > On Mon, 2011-12-12 at 10:02 -0800, Dmitry Torokhov wrote:
> > > 1 is a power of two, therefore rounddown_pow_of_two(1) should return 1.
> > 
> > x^0 = 1
> > x^1 = x
> > 
> > Seems to me 0 was the right answer, no?
> 
> Eh? The answer should be the power-of-two (1), not the exponent (0).

Yeah, just noticed that, see my other reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/