linux-kernel - Re: [PATCH][Regression fix] PCI / Hotplug: Always allow acpiphp to handle non-PCIe bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201112132209.04185.rjw@sisk.pl>
Date:	Tue, 13 Dec 2011 22:09:04 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
Subject: Re: [PATCH][Regression fix] PCI / Hotplug: Always allow acpiphp to handle non-PCIe bridges

On Tuesday, December 13, 2011, Jesse Barnes wrote:
> On Tue, 13 Dec 2011 00:02:28 +0100
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> 
> > From: Rafael J. Wysocki <rjw@...k.pl>
> > 
> > Commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a (PCI / ACPI: Make
> > acpiphp ignore root bridges using PCIe native hotplug) added code
> > that made the acpiphp driver completely ignore PCIe root complexes
> > for which the kernel had been granted control of the native PCIe
> > hotplug feature by the BIOS through _OSC.  Unfortunately, however,
> > this was a mistake, because on some systems there were PCI bridges
> > supporting PCI (non-PCIe) hotplug under such root complexes and
> > those bridges should have been handled by acpiphp.
> > 
> > For this reason, revert the changes made by the commit mentioned
> > above and make register_slot() in drivers/pci/hotplug/acpiphp_glue.c
> > avoid registering hotplug slots for PCIe ports that belong to
> > root complexes with native PCIe hotplug enabled (which means that
> > the BIOS has granted the kernel control of this feature for the
> > given root complex).  This is reported to address the original
> > issue fixed by commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a and
> > to work on the system where that commit broke things.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> > ---
> 
> Applied to my for-linus branch.  I'll probably send to Linus on Thu. or
> so.
> 
> I also rebased the breakage out of linux-next.

Thanks a lot!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/