linux-kernel - RE: [PATCH v6] pinctrl: add a pin config interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF1751860BDA@HQMAIL01.nvidia.com>
Date:	Tue, 13 Dec 2011 13:49:15 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Haojian Zhuang <haojian.zhuang@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>
CC:	Linus Walleij <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...vell.com>
Subject: RE: [PATCH v6] pinctrl: add a pin config interface

Haojian Zhuang wrote at Tuesday, December 13, 2011 12:22 AM:
> On Tue, Dec 13, 2011 at 8:22 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> > On Mon, Dec 12, 2011 at 7:19 AM, Haojian Zhuang
> > <haojian.zhuang@...il.com> wrote:
> >
> >> You mentioned that pin_config_set() is used in below.
> >> ret = pin_config_set(dev, "FOO_GPIO_PIN", PLATFORM_X_PULL_UP);
> >>
> >> struct pinctrl_dev is created while pinmux is registered. I think this
> >> structure is always internal structure. It can't be observed by
> >> platform driver or device driver.
> >
> > True. Was fixed today by a patch from Stephen Warren that
> > simply cuts out the middleman and use the original platform
> > device directly. Kudos to Stephen for fixing this!
> >
> > Linus Walleij
> 
> Excuse me that I didn't find that patch. Did you merge it into your
> git tree? The latest patch on pinconf.c is updating pdev->dev to
> &pdev->dev.

I just hit the same problem. This isn't what my patch addresses.

My patch prevents the pinctrl core from creating a struct device for the
pin controller, since it already has one.

The problem that Haojian mentions is regarding struct pinctrl_dev, not
plain device.

I'd suggest modifying all the pin_config_* APIs to take a device name
rather than a "struct pinctrl_dev *". I'll work on a patch to do this,
since I'm hitting the same problem.

An alternative may be to either:

* Add function pinctrl_get_dev_by_name(name)

Or:

* Use dev = bus_find_device_by_name(name) to get the plain device, and
add a pinctrl_find_dev_by_dev(dev).

Either of those sound more complex though, but I suppose do allow
direct operation if you somehow do already have the struct pinctrl_dev.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/