linux-kernel - Re: [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1323814611.3837.40.camel@joe2Laptop>
Date:	Tue, 13 Dec 2011 14:16:51 -0800
From:	Joe Perches <joe@...ches.com>
To:	Denis Kuzmenko <linux@...onet.org.ua>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH v3 resend2] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS
 driver use gpiolib

On Wed, 2011-12-14 at 00:05 +0200, Denis Kuzmenko wrote:
> On 12/13/2011 11:40 PM, Joe Perches wrote:
> > On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote:
> >> On 12/13/2011 11:28 PM, Joe Perches wrote:
> >>> The LEDF_ACTLOW use is dependent on it being #defined
> >>> to 1 when using ^.  I think that's unintelligible.
> >> Sorry, can't understand. Can you please clarify last two sentences?
> > 	s3c2410_gpio_setpin(pd->gpio, (value ? 1 : 0) ^
> > 			    (pd->flags & S3C24XX_LEDF_ACTLOW));
> > I think this should be:
> > 	s3c2410_gpio_setpin(pd->gpio,
> > 			    !!value ^ !!(pd->flags & S3C24XX_LEDF_ACTLOW));
> So you've found a BUG.

It's not really a bug, it's more lack of consistency
style defect.  It's also an example of why I prefer
consistent style to equivalent but different styles.

> As I understand my code will behave wrong if
> S3C24XX_LEDF_ACTLOW value will be changed.

> Thank you, I'll make a new version.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/