linux-kernel - Re: [PATCH v4 3/6] clk: introduce the common clock framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111214074922.GM28768@b20223-02.ap.freescale.net>
Date:	Wed, 14 Dec 2011 15:50:04 +0800
From:	Richard Zhao <richard.zhao@...escale.com>
To:	Mike Turquette <mturquette@...aro.org>
CC:	<linux@....linux.org.uk>, <andrew@...n.ch>,
	<linaro-dev@...ts.linaro.org>, <eric.miao@...aro.org>,
	<grant.likely@...retlab.ca>, <jeremy.kerr@...onical.com>,
	<mturquette@...com>, <sboyd@...cinc.com>, <magnus.damm@...il.com>,
	<dsaxena@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
	<arnd.bergmann@...aro.org>, <patches@...aro.org>,
	<tglx@...utronix.de>, <linux-omap@...r.kernel.org>,
	<richard.zhao@...aro.org>, <shawn.guo@...escale.com>,
	<paul@...an.com>, <linus.walleij@...ricsson.com>,
	<broonie@...nsource.wolfsonmicro.com>,
	<linux-kernel@...r.kernel.org>, <amit.kucheria@...aro.org>,
	<skannan@...cinc.com>
Subject: Re: [PATCH v4 3/6] clk: introduce the common clock framework

Hi Mike,
> + *
> + * @recalc_rate	Recalculate the rate of this clock, by quering hardware
> + * 		and/or the clock's parent. It is up to the caller to insure
> + * 		that the prepare_mutex is held across this call.  Returns the
> + * 		calculated rate.  Optional, but recommended - if this op is not
> + * 		set then clock rate will be initialized to 0.
I'm still concerned, if it's NULL, why don't just retrun parent's rate if it has? 
 
Thanks
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/