linux-kernel - Re: [PATCH 4/7] x86, mce: create helper function to save addr/misc when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111214160929.GI23589@aftab>
Date:	Wed, 14 Dec 2011 17:09:29 +0100
From:	Borislav Petkov <bp@...64.org>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	Ingo Molnar <mingo@...e.hu>, "Huang, Ying" <ying.huang@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/7] x86, mce: create helper function to save addr/misc
 when needed

On Tue, Dec 13, 2011 at 09:44:07AM -0800, Luck, Tony wrote:
> > Am I reading this correctly in that you need to cut off the same amount
> > of bits on both sides of MCi_ADDR and the address magnitude coincides
> > with the left shift amount? I.e. and for example, if MCi_ADDR[44:3]
> > and you need to cut off 3 bits of both sides to get a 48-bit physical
> > address?
> 
> No - just masking bits at the low end (shift right and the bits we don't
> want fall into the bit bucket, shift left by the same amount and we fill
> those spots with zeroes).  Upper bits are unchanged.

Doh, of course, I must be drunk. Please disregard this comment.

> 
> I could write it as:
> 			m->addr &= ~((1ull << shift) - 1);

> 
> But I think the shift-right, shift-left is used elsewhere in the kernel too.

No, yours is fine.

ACK.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/