linux-kernel - Re: Is per_cpu_ptr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUr3MqwWzeD4Z8KzyErEM4utT=CkpbyecPu75-QDDznHQ@mail.gmail.com>
Date:	Thu, 15 Dec 2011 00:17:15 +0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Petr Tesarik <ptesarik@...e.cz>
Cc:	linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>,
	Vivek Goyal <vgoyal@...hat.com>
Subject: Re: Is per_cpu_ptr_to_phys broken?

On Wed, Dec 14, 2011 at 7:33 AM, Petr Tesarik <ptesarik@...e.cz> wrote:
> Hi folks,
>
...
>
> Now, the per_cpu_ptr_to_phys() function aligns all vmalloc addresses to a page
> boundary. This was probably right when Vivek Goyal introduced that function
> (commit 3b034b0d084221596bf35c8d893e1d4d5477b9cc), because per-cpu addresses
> were only allocated by vmalloc if booted with percpu_alloc=page, but this is
> no longer the case, because per-cpu variables are now always allocated that
> way AFAICS.
>
> So, shouldn't we add the offset within the page inside per_cpu_ptr_to_phys?
>

Hi,

Tejun already fixed this, see:

commit	a855b84c3d8c73220d4d3cd392a7bee7c83de70e
percpu: fix chunk range calculation
author	Tejun Heo <tj@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/