linux-kernel - Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYHtgx3Qgx4QRdgOahQXjvSWE_iogWCZjaYQ-VnyS62uQ@mail.gmail.com>
Date:	Wed, 14 Dec 2011 23:15:53 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Dong Aisheng <b29396@...escale.com>, linus.walleij@...ricsson.com,
	linux-kernel@...r.kernel.org, rob.herring@...xeda.com,
	grant.likely@...retlab.ca, linux-arm-kernel@...ts.infradead.org,
	kernel@...gutronix.de, shawn.guo@...escale.com
Subject: Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem

On Wed, Dec 14, 2011 at 10:11 PM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> On Thu, Dec 15, 2011 at 12:03:42AM +0800, Dong Aisheng wrote:

>> +     pmx = pinmux_get(&pdev->dev, NULL);
>> +     if (IS_ERR(pmx)) {
>> +             err = PTR_ERR(pmx);
>> +             goto err_pmx_get;
>> +     }
>> +     err = pinmux_enable(pmx);
>> +     if (err)
>> +             goto err_pmx_enable;
>> +     imx_data->pmx = pmx;
>> +
>
> Won't this break every i.MX except i.MX6?

Not this patch on its own, first the machines have to
select PINCTRL
select PINMUX_FOO

*Then* it will break :-D

So if you want to do this for i.MX you need something like
selectable dummy pinmuxes, i.e. pinmux_get() to return something
that just say "OK" to everything like the dummy regulators.

Shall I try to create something like that?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/