linux-kernel - Re: [PATCH 2/3] make clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EE80A0D.7090808@cn.fujitsu.com>
Date:	Wed, 14 Dec 2011 10:29:33 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Glauber Costa <glommer@...allels.com>,
	linux-kernel@...r.kernel.org, jbottomley@...allels.com,
	cgroups@...r.kernel.org, bsingharora@...il.com, devel@...nvz.org,
	kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH 2/3] make clone_children a flag

Tejun Heo wrote:
> On Sun, Dec 11, 2011 at 03:45:37PM +0100, Glauber Costa wrote:
>> There is no reason to have a flags field, and then a separate
>> bool field just to indicate if the clone_children flag is set.
>> Make it a flag
>>
>> Signed-off-by: Glauber Costa <glommer@...allels.com>
> 
> Doesn't this change how remount conditions are checked?
> 

Right. Currently we can do this:

	# mount -t cgroup xxx /mnt
	# mount -o remount,clone_children /mnt

with this patch, the above remount will fail.

But..the current bevaiour of remount is a bit confusing in that remount
with/without "clone_children" has no effect on anything:

	# mount -t cgroup -o clone_children xxx /mnt
	# cat /mnt/cgroup.clone_children
	1
	# mount -o remount xxx /mnt
	# mount | grep cgroup
	xxx on /mnt type cgroup (rw,clone_children)
	# cat /mnt/cgroup.clone_children
	1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/