linux-kernel - Re: [PATCH] AIO: Don't plug the I/O queue in do_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Dec 2011 09:09:04 +0800
From:	Shaohua Li <shli@...nel.org>
To:	Dave Kleikamp <dave.kleikamp@...cle.com>
Cc:	linux-aio@...ck.org, linux-kernel@...r.kernel.org,
	Chris Mason <chris.mason@...cle.com>,
	Jens Axboe <axboe@...nel.dk>, Andi Kleen <ak@...ux.intel.com>,
	Jeff Moyer <jmoyer@...hat.com>
Subject: Re: [PATCH] AIO: Don't plug the I/O queue in do_io_submit()

2011/12/14 Dave Kleikamp <dave.kleikamp@...cle.com>:
> Asynchronous I/O latency to a solid-state disk greatly increased
> between the 2.6.32 and 3.0 kernels. By removing the plug from
> do_io_submit(), we observed a 34% improvement in the I/O latency.
>
> Unfortunately, at this level, we don't know if the request is to
> a rotating disk or not.
>
> Signed-off-by: Dave Kleikamp <dave.kleikamp@...cle.com>
> Cc: linux-aio@...ck.org
> Cc: Chris Mason <chris.mason@...cle.com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Jeff Moyer <jmoyer@...hat.com>
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 78c514c..d131a2c 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1696,7 +1696,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>        struct kioctx *ctx;
>        long ret = 0;
>        int i = 0;
> -       struct blk_plug plug;
>        struct kiocb_batch batch;
>
>        if (unlikely(nr < 0))
> @@ -1716,8 +1715,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>
>        kiocb_batch_init(&batch, nr);
>
> -       blk_start_plug(&plug);
> -
>        /*
>         * AKPM: should this return a partial result if some of the IOs were
>         * successfully submitted?
> @@ -1740,7 +1737,6 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>                if (ret)
>                        break;
>        }
> -       blk_finish_plug(&plug);
>
>        kiocb_batch_free(&batch);
>        put_ioctx(ctx);
can you explain why this can help? Note, in 3.1 kernel we now force flush
plug list if the list is too long, which will remove a lot of latency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/