linux-kernel - Re: [PATCH 1/1] r8169.c correct MSIEnable register offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111215.014359.1153990753442293322.davem@davemloft.net>
Date:	Thu, 15 Dec 2011 01:43:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	cantona@...tona.no-ip.org, hayeswang@...ltek.com,
	linux-kernel@...r.kernel.org, nic_swsd@...ltek.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] r8169.c correct MSIEnable register offset

From: Francois Romieu <romieu@...zoreil.com>
Date: Wed, 14 Dec 2011 22:37:13 +0100

> Su Kang Yin <cantona@...tona.no-ip.org> :
>> correct MSIEnable (bit 5) register to Config1 (offset 0x52) instead of
>> Config2 (offset 0x53)
> 
> I wonder where the inspiration for the MSIEnable bit came from.
> It looks like something was confused with the Message Control word
> in PCI space.
> 
> Imho you can simply remove it altogether.

Someone should find out what the real situation is with this.

Maybe it mirrors the PCI config space setting and is read-only, maybe
not.  But it should be determined for sure before changing this. :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/