linux-kernel - Re: [Qemu-devel] [PATCH 2/2] device_isolation: Support isolation on POWER p7ioc (IODA) bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323931718.13200.1.camel@concordia>
Date:	Thu, 15 Dec 2011 17:48:38 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	David Gibson <david@...son.dropbear.id.au>
Cc:	alex.williamson@...hat.com, chrisw@...hat.com, aik@...abs.ru,
	agraf@...e.de, qemu-devel@...gnu.org, B08248@...escale.com,
	iommu@...ts.linux-foundation.org, joerg.roedel@....com,
	scottwood@...escale.com, dwmw2@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Qemu-devel] [PATCH 2/2] device_isolation: Support isolation on
 POWER p7ioc (IODA) bridges

On Thu, 2011-12-15 at 17:08 +1100, David Gibson wrote:
> This patch adds code to the code for the powernv platform to create
> and populate isolation groups on hardware using the p7ioc (aka IODA) PCI host
> bridge used on some IBM POWER systems.

> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 0cdc8302..6df632e 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -861,6 +862,9 @@ static void __devinit pnv_ioda_setup_bus_dma(struct pnv_ioda_pe *pe,
>  		set_iommu_table_base(&dev->dev, &pe->tce32_table);
>  		if (dev->subordinate)
>  			pnv_ioda_setup_bus_dma(pe, dev->subordinate);
> +#ifdef CONFIG_DEVICE_ISOLATION
> +		device_isolation_dev_add(&pe->di_group, &dev->dev);
> +#endif

You already have a nop version of that in device_isolation.h, so the
ifdef is not required AFAICS.

And similarly elsewhere.

cheers



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)