linux-kernel - Re: [PATCH] asus-wmi: explicitly set the wireless LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1323937607.3337.6.camel@jlt3.sipsolutions.net>
Date:	Thu, 15 Dec 2011 09:26:47 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Corentin Chary <corentin.chary@...il.com>
Cc:	Keng-Yu Lin <kengyu@...onical.com>,
	Matthew Garrett <mjg@...hat.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] asus-wmi: explicitly set the wireless LED

On Thu, 2011-12-15 at 09:25 +0100, Corentin Chary wrote:

> > static const char *rfkill_ledtrigname(struct rfkill *rfkill)
> > {
> > #ifdef CONFIG_RFKILL_LEDS
> >        return rfkill->ledtrigname;
> > #endif
> >        return NULL;
> > }

> Right, but is rfkill->ledtrigname really set somewhere ?
> 
> rfkill->led_trigger.name seems safer to use.

Hm, indeed -- looks like we can get rid of ledtrigname completely since
nothing ever touches it.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/