linux-kernel - Re: printk() vs tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323943005.18942.18.camel@twins>
Date:	Thu, 15 Dec 2011 10:56:45 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ted Ts'o <tytso@....edu>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Greg KH <greg@...ah.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: printk() vs tty_io

On Wed, 2011-12-14 at 07:54 -0800, Linus Torvalds wrote:

> Ugh. There is a *ton* of stuff inside that serial port lock,
> including, yes, the uart_write_wakeup().
> 
> And it does look like it's protecting port->tty or something, so I
> don't see that we can just move the wakeup to outside the lock, which
> was my first reaction.

We probably could, I can have a closer look, but the main question is,
are we going to commit to no wakeups from console implementations? That
would mean removing the USB serial console support and other such stuff.

[ Personally I think USB serial console is insane, if you really need
something like that use the ehci-dbgp thing, that at least has a chance
of working. ]

If we're not going to commit to that (which would be valid choice given
where we are), my printk efforts are pointless and I'll reconsider.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/