linux-kernel - Re: [PATCH] input: signedness bug in cma3000_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12775.1323916035@turing-police.cc.vt.edu>
Date:	Wed, 14 Dec 2011 21:27:15 -0500
From:	Valdis.Kletnieks@...edu
To:	Xi Wang <xi.wang@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: signedness bug in cma3000_thread_irq()

On Mon, 12 Dec 2011 01:49:26 EST, Xi Wang said:
> The error check (intr_status < 0) didn't work because intr_status is
> a u8.  Change its type to signed int.
>
> Signed-off-by: Xi Wang <xi.wang@...il.com>
> ---
>  drivers/input/misc/cma3000_d0x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c

That will fix the signed/unsigned issue.  However, was there a reason
the field was an 8-bit-wide to begin with?

Content of type "application/pgp-signature" skipped