linux-kernel - Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADZ9YHi4XX4gzPvbqxBndgNGoMMNzdQH9DqjC4fT7bKRpxjcXQ@mail.gmail.com>
Date:	Thu, 15 Dec 2011 23:16:52 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c

On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@....com> wrote:
> (again with mailing lists on Cc, sorry)
>
> Hi,
>
> I tested current linux-next against my iommu-configs and found a compile
> error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> sst_platform_open() function is used but not declared. Attached patch
> fixes this.
>

While fixing any kind of error/warning, it's nice to have
error/warning message in changelog.

Thanks,
Rakib

> From d4e6d3b9ff8084c02eaf50e8212f77bcde5dec9d Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@....com>
> Date: Thu, 15 Dec 2011 17:39:31 +0100
> Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
>
> The variable ret_val is used but not declared. Fix this.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> ---
>  sound/soc/mid-x86/sst_platform.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
> index 24f9471..11c39c5 100644
> --- a/sound/soc/mid-x86/sst_platform.c
> +++ b/sound/soc/mid-x86/sst_platform.c
> @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
>  {
>        struct snd_pcm_runtime *runtime = substream->runtime;
>        struct sst_runtime_stream *stream;
> +       int ret_val;
>
>        pr_debug("sst_platform_open called\n");
>
> --
> 1.7.5.4
>
> --
> AMD Operating System Research Center
>
> Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
> General Managers: Alberto Bozzo, Andrew Bowd
> Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/