linux-kernel - Re: [PATCH] usb: musb: fix pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111215235205.GB2242@legolas.emea.dhcp.ti.com>
Date:	Fri, 16 Dec 2011 01:52:06 +0200
From:	Felipe Balbi <balbi@...com>
To:	Greg KH <greg@...ah.com>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] usb: musb: fix pm_runtime mismatch

On Thu, Dec 15, 2011 at 03:11:03PM -0800, Greg KH wrote:
> On Thu, Dec 15, 2011 at 03:02:25PM -0800, Greg KH wrote:
> > On Fri, Dec 16, 2011 at 12:42:14AM +0200, Felipe Contreras wrote:
> > > In musb_init_controller() there's a pm_runtime_put(), but there's no
> > > pm_runtime_get(), which creates a mismatch that causes the driver to
> > > sleep when it shouldn't.
> > > 
> > > This was introduced in 7acc619, but it wasn't triggered until 18a2689
> > > was merged to Linus' branch at point 6899608.
> > > 
> > > However, it seems most of the time this is used in a way that keeps the
> > > counter above 0, so nobody noticed. Also, it seems to depend on the
> > > configuration used.
> > > 
> > > I found the problem by loading isp1704_charger before any usb gadgets:
> > > http://article.gmane.org/gmane.linux.kernel/1226122
> > > 
> > > All versions after 2.6.39 are affected.
> > > 
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> > > ---
> > >  drivers/usb/musb/musb_core.c |    2 --
> > >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > Will you be including this in your next pull request for me to include
> > in my tree to go to Linus soon?
> 
> Doh, wrong Felipe, my apologies.

hehe. To answer the previous question: I want to hash a few things out
first, so it's likely that it won't make it for the next pull request to
Linus. Guess I'll have to send this either on 3.3 merge window or after
that and, of course, Cc stable (as Felipe C. did)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)