linux-kernel - Re: [PATCH] serial/imx: propagate error from of_alias_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFQ4atSVe26uwX5xw5yEW1Dgs7KFxdB+Msg9PkkfpSswtsnDoA@mail.gmail.com>
Date:	Thu, 15 Dec 2011 10:59:34 +0800
From:	Jason Hui <jason.hui@...aro.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org,
	Shawn Guo <shawn.guo@...aro.org>,
	Alan Cox <alan@...ux.intel.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Jeremy Kerr <jeremy.kerr@...onical.com>,
	Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH] serial/imx: propagate error from of_alias_get_id instead
 of using -ENODEV

2011/12/15 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> A quick look at of_alias_get_id shows that in the error case it returns
> -ENODEV, too, but still it's better style to propagate the value as is.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Alan Cox <alan@...ux.intel.com>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Jeremy Kerr <jeremy.kerr@...onical.com>
> Cc: Jason Liu <jason.hui@...aro.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> ---
>  drivers/tty/serial/imx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 163fc90..75c159a 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1301,7 +1301,7 @@ static int serial_imx_probe_dt(struct imx_port *sport,
>        ret = of_alias_get_id(np, "serial");
>        if (ret < 0) {
>                dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret);
> -               return -ENODEV;
> +               return ret;
>        }
>        sport->port.line = ret;

Acked-by: Jason Liu <jason.hui@...aro.org>

>
> --
> 1.7.7.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/