lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111216084029.GB4170@elte.hu>
Date:	Fri, 16 Dec 2011 09:40:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Nikunj A Dadhania <nikunj@...ux.vnet.ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Joerg Roedel <joerg.roedel@....com>
Subject: Re: Latest tip kernel(3.2-rc1-tip_cf6b3899) fails to boot on x3850x5
 machine


* Yinghai Lu <yinghai@...nel.org> wrote:

>  config X86_X2APIC
>  	bool "Support x2apic"
> -	depends on X86_LOCAL_APIC && X86_64 && IRQ_REMAP
> +	depends on X86_LOCAL_APIC && X86_64
> +	select IRQ_REMAP

IRQ_REMAP is a 'complex' option:

config IRQ_REMAP
        bool "Support for Interrupt Remapping (EXPERIMENTAL)"
        depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI && EXPERIMENTAL
        select DMAR_TABLE

and selecting such complex options is generally dangerous, as 
the sub-dependencies are not explicitly selected. So if say 
PCI_MSI or ACPI are disabled, the select will still be performed 
by X86_X2APIC.

Can we make the IRQ_REMAP default depend on X86_X2APIC or so, to 
solve this problem?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ