linux-kernel - leds: leds-tca6507: off by one in choose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20111216123125.GA2721@elgon.mountain>
Date:	Fri, 16 Dec 2011 15:31:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	NeilBrown <neilb@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: leds: leds-tca6507: off by one in choose_times()

Hi Neil,

Smatch complains about 7a9244d89523 "leds: add driver for TCA6507 LED
controller"

drivers/leds/leds-tca6507.c +185 choose_times(16)
	error: buffer overflow 'time_codes' 16 <= 16

   184          for (c1 = 1; c1 <= TIMECODES; c1++) {
   185                  int t = time_codes[c1];
                                ^^^^^^^^^^^^^
We're reading 1 past the end of the array here.

   186                  if (t*2 < tmin)
   187                          continue;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/