linux-kernel - Re: [patch 1/2]block, cfq: fix empty queue crash caused by request merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4EEB4001.8010205@kernel.dk>
Date:	Fri, 16 Dec 2011 13:56:33 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Shaohua Li <shaohua.li@...el.com>
CC:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/2]block, cfq: fix empty queue crash caused by request
 merge

On 2011-12-16 02:52, Shaohua Li wrote:
> All requests of a queue could be merged to other requests of other queue.
> Such queue will not have request in it, but it's in service tree. This
> will cause kernel oops.
> I encounter a BUG_ON() in cfq_dispatch_request() with next patch, but the
> issue should exist without the patch.

Good catch, yes I think this could happen if you just happen to have a
very deliberate/unlucky set of processes and timings. Applied.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/