linux-kernel - Re: [alsa-devel] [PATCH] Jabra SPEAK 410 USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4EEB4C51.4010205@ladisch.de>
Date:	Fri, 16 Dec 2011 14:49:05 +0100
From:	Clemens Ladisch <clemens@...isch.de>
To:	"Richard W.M. Jones" <rjones@...hat.com>
CC:	alsa-devel@...a-project.org, Tom Walder <tom.walder@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] Jabra SPEAK 410 USB - no audio playback

Richard W.M. Jones wrote:
> The attached patch fixes USB audio support for the Jabra SPEAK 410 USB.
>
> The problem, as I understand it, is that the device contains a
> Class-Specific Endpoint (CS_ENDPOINT) descriptor before the Endpoint
> (ENDPOINT) descriptor.  The USB code all assumes that CS_ENDPOINT can
> only appear after ENDPOINT.  Therefore the USB code divides up the
> interface descriptor into "stuff before ENDPOINT" (in
> interface->extra) and "stuff after ENDPOINT" (in
> interface->endpoint[0]->extra).  For this device, this division does
> not work.
>
> The solution (which is a hack ...) is to also search interface->extra
> looking for the missing descriptor.

The patch looks good.  Please run it through checkpatch.pl and provice
a Signed-off-by tag (see Documentation/SubmittingPatches).


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/