linux-kernel - Re: [PATCH 1/4] ACPI: EC: Add ec_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Dec 2011 08:18:54 -0600
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Thomas Renninger <trenn@...e.de>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>, Len Brown <lenb@...nel.org>,
	Azael Avalos <coproscefalo@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Henrique de Moraes Holschuh <hmh@....eng.br>
Subject: Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

On Fri, Dec 16, 2011 at 02:19:32PM +0100, Thomas Renninger wrote:
> On Friday, December 16, 2011 01:33:33 AM Matthew Garrett wrote:
> > On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote:
> > 
> > > I think best is to move the thinkpad implementation of getting
> > > ACPI handles based on HIDs to osl.c and make it global.
> > > I'll send patches.
> > > Please review them carefully, they are only compile tested.
> > 
> > The ec driver is already finding the hardware on the basis of the HID - 
> > is there any reason to do this twice rather than just exporting the 
> > information the ec driver already has?
> 
> I don't object to export ec_handle, but thinkpad_acpi.c should get
> adjusted as well.
> 
> I had a closer look and can come up with a replacement for acpi_get_devices
> using bus.c matching function bus_find_device() avoiding the namespace
> walk.

My thought was the same as Matthew's, why bother redoing the work that
the EC driver has already done. I'm open to doing it either way though.
What your proposing does look useful independant of whether or not we
use it for finding the EC.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/