linux-kernel - Re: checkpatch.pl misreporting bugs with array fillings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAq6er31hkB++ROFdA0OxCEn9LBEW_StVa+CvMrzkKnCJayF_w@mail.gmail.com>
Date:	Fri, 16 Dec 2011 22:24:33 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: checkpatch.pl misreporting bugs with array fillings

On Fri, Dec 16, 2011 at 9:59 PM, Marek Vasut <marek.vasut@...il.com> wrote:
> Hi,
>
> the following testcase is probably misreported by checkpatch.pl:
>
> static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
>        {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>        {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> };
>
> The result is:
>
> ERROR: space prohibited before open square bracket '['
> #2: FILE: testcase.c:2:
> +       {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>
> ERROR: space prohibited before open square bracket '['
> #3: FILE: testcase.c:3:
> +       {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>
> total: 2 errors, 0 warnings, 5 lines checked
>
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> MULTISTATEMENT_MACRO_USE_DO_WHILE
>
> testcase.c has style problems, please review.

Hmmm will have a look...

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/