linux-kernel - Re: checkpatch.pl misreporting bugs with array fillings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201112170122.55827.marek.vasut@gmail.com>
Date:	Sat, 17 Dec 2011 01:22:55 +0100
From:	Marek Vasut <marek.vasut@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...dowen.org>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch.pl misreporting bugs with array fillings

> On Fri, 2011-12-16 at 22:59 +0100, Marek Vasut wrote:
> > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
> > 
> >         {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> >         {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > 
> > };
> 
> True.
> 
> Andy will probably figure it out.
> He's the maintainer.
> 
> Still, in this case all the 0's are unnecessary.
> I'd probably write that code as:
> 
> static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
> 	{ [7] = 27, [8] = 27 },
> 	{ [7] = 29, [8] = 29 },
> };

I suspect this is some remnant of ancient code where the people writing it were 
not sure if the memory under this is all-zeroes. (or the section this lands in 
wasn't zeroed-out)

M
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/