lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Dec 2011 09:36:14 +0100 From: Ingo Molnar <mingo@...e.hu> To: Alan Cox <alan@...rguk.ukuu.org.uk> Cc: linux-kernel@...r.kernel.org, Michael Demeter <michael.demeter@...el.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Subject: Re: [PATCH] Added some addition debug prints for pb_keys * Alan Cox <alan@...rguk.ukuu.org.uk> wrote: > From: Michael Demeter <michael.demeter@...el.com> > > Added additional debug output that we always seem to add > during power ons to validate firmware operation. > > Signed-off-by: Michael Demeter <michael.demeter@...el.com> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> > Signed-off-by: Alan Cox <alan@...ux.intel.com> > --- > > arch/x86/platform/mrst/mrst.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c > index a9a4732..3002cc86 100644 > --- a/arch/x86/platform/mrst/mrst.c > +++ b/arch/x86/platform/mrst/mrst.c > @@ -1035,6 +1035,8 @@ static int __init pb_keys_init(void) > num = sizeof(gpio_button) / sizeof(struct gpio_keys_button); > for (i = 0; i < num; i++) { > gb[i].gpio = get_gpio_by_name(gb[i].desc); > + pr_debug("info[%2d]: name = %s," > + "gpio = %d\n", i, gb[i].desc, gb[i].gpio); I've fixed this to lie on a single line - there's no point in line-breaking pr_debug()s in general - especially not the format string. Note that merging the format string unearthed a small formatting ugly: "info[%2d]: name = %s,gpio = %d\n" I edited that to the probably intended: "info[%2d]: name = %s, gpio = %d\n" Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists