linux-kernel - Re: [PATCH] apb: Fix configuration constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111218093250.GA19092@elte.hu>
Date:	Sun, 18 Dec 2011 10:32:50 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH] apb: Fix configuration constraints


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> From: Alan Cox <alan@...ux.intel.com>
> 
> The APB timer requires SFI, SCU and MID support
> 
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>

Even with all you latest Kconfig fixes i get trivial build 
failures:

  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/x86/built-in.o: In function `apbt_cpuhp_notify':
apb_timer.c:(.text+0x14b91): undefined reference to `dw_apb_clockevent_pause'
apb_timer.c:(.text+0x14ba5): undefined reference to `dw_apb_clockevent_stop'
arch/x86/built-in.o: In function `apbt_set_mapping':
apb_timer.c:(.text+0x14c86): undefined reference to `dw_apb_clocksource_init'
arch/x86/built-in.o: In function `apbt_setup_secondary_clock':
(.text+0x14cf3): undefined reference to `dw_apb_clockevent_init'
arch/x86/built-in.o: In function `apbt_setup_secondary_clock':
(.text+0x14d06): undefined reference to `dw_apb_clockevent_resume'
arch/x86/built-in.o: In function `apbt_setup_secondary_clock':
(.text+0x14d73): undefined reference to `dw_apb_clockevent_register'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14d97): undefined reference to `dw_apb_clocksource_start'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14da1): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14db1): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14dde): undefined reference to `dw_apb_clocksource_start'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14de8): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_quick_calibrate':
(.text+0x14e04): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb17c): undefined reference to `dw_apb_clocksource_start'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb186): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb1b5): undefined reference to `dw_apb_clocksource_read'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb1d9): undefined reference to `dw_apb_clocksource_register'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb24b): undefined reference to `dw_apb_clockevent_init'
arch/x86/built-in.o: In function `apbt_time_init':
(.init.text+0xb281): undefined reference to `dw_apb_clockevent_register'

In fact on latest tip:x86/platform i get:

arch/x86/platform/mrst/mrst.c:306:37: error: ‘apbt_setup_secondary_clock’ undeclared (first use in this function)

Have all your recent Kconfig patches applied there, with 
probably one of them mixed up:

arch/x86/Kconfig:393:error: recursive dependency detected!

Config attached.

Thanks,

	Ingo

View attachment "config" of type "text/plain" (78667 bytes)