linux-kernel - Re: [PATCH] sched: Simplify task_group_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8762heumqs.fsf@linux.vnet.ibm.com>
Date:	Sun, 18 Dec 2011 17:15:31 +0530
From:	Nikunj A Dadhania <nikunj@...ux.vnet.ibm.com>
To:	Sisir Koppaka <sisir.koppaka@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Simplify task_group_is_autogroup

On Sun, 18 Dec 2011 15:42:53 +0530, Sisir Koppaka <sisir.koppaka@...il.com> wrote:
> Removing the !! in task_group_is_autogroup doesn't impede functionality.
> 
> Tested with and without CONFIG_SCHED_AUTOGROUP.
> 
> Signed-off-by: Sisir Koppaka <sisir.koppaka@...il.com>
> ---
>  kernel/sched/auto_group.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/sched/auto_group.h b/kernel/sched/auto_group.h
> index 8bd0471..f628798 100644
> --- a/kernel/sched/auto_group.h
> +++ b/kernel/sched/auto_group.h
> @@ -21,7 +21,7 @@ extern void autogroup_free(struct task_group *tg);
> 
>  static inline bool task_group_is_autogroup(struct task_group *tg)
>  {
> -	return !!tg->autogroup;
> +	return tg->autogroup;
>
The return is supposed to be a boolean. So the code is correct.

Regards,
Nikunj

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/