linux-kernel - Re: [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201112181501.36299.trenn@suse.de>
Date:	Sun, 18 Dec 2011 15:01:35 +0100
From:	Thomas Renninger <trenn@...e.de>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	Azael Avalos <coproscefalo@...il.com>,
	Matthew Garrett <mjg@...hat.com>, Len Brown <lenb@...nel.org>,
	platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces

On Saturday 17 December 2011 16:07:42 Seth Forshee wrote:
> On Sat, Dec 17, 2011 at 04:32:14AM -0700, Azael Avalos wrote:
> > 2011/12/17 Thomas Renninger <trenn@...e.de>:
> > > On Thursday 15 December 2011 19:06:09 Seth Forshee wrote:
> > > ...
> > >> +static bool toshiba_acpi_i8042_filter(unsigned char data, unsigned char str,
> > >> +                                   struct serio *port)
> > >> +{
> > >> +     if (str & 0x20)
> > >> +             return false;
> > >> +
> > >> +     if (unlikely(data == 0xe0))
> > >> +             return false;
> > >> +
> > >> +     if ((data & 0x7f) == TOS1900_FN_SCAN) {
> > >> +             schedule_work(&toshiba_acpi->hotkey_work);
> > >> +             return true;
> > >> +     }
> > > What have you tried to check whether some other kind of ACPI event
> > > is happening?
> > > Do any acpi/SCI interrupts happen?:
> > > watch -n1 "cat /proc/interrupts |grep acpi"
> > 
> > I already did this, no events whatsoever, I was using a Satellite X205
> > at the time
> 
> I've done similar checks on the NB505, no events.
Ok.

> > > Could it by chance be an EC or other device GPE/SCI?
> > >
> > 
> > Seth mentioned me something about this, but w/o proper docs from
> > Toshiba, we are blindly shooting.
> > 
> > Seth?
> 
> In the DSDTs I've inspected there is an EC query method that looks like
> it handles events for the hotkeys, but I've never been able to find
> anything that will cause the GPE to trigger when the hotkeys are
> pressed.
Be careful, those EC event notifications do not show up in:
/sys/firmware/acpi/interrupts/gpe*
If no acpi irqs are happening (you said you've tried already):
watch -n1 "cat /proc/interrupts |grep acpi"
filtering the key events sounds appropriate.
I see you dig quite a bit already:

> Interestingly, I also saw that the Windows hotkey driver for the NB505
> logs some messages that indicate it's also filtering Fn key presses, and
> I also found that the binary contains the NTFY string. That's not proof
> of anything, but it does suggest that the Windows driver might be doing
> something similar to support hotkeys. Which makes me wonder if the GPE
> works at all.

Nice work.

   Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/